Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed issue#2004 parsing solc verison with trailing newlines #2005

Merged
merged 2 commits into from Jan 13, 2023
Merged

fixed issue#2004 parsing solc verison with trailing newlines #2005

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
10c0075
fixed issue#2004 parsing solc verison with trailing newlines
elizabethdinella Jan 3, 2023
878c595
suggested changes
elizabethdinella Jan 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions ethers-solc/src/compile/mod.rs
View file
Open in desktop
Expand Up @@ -686,6 +686,7 @@ fn version_from_output(output: Output) -> Result<Version> {
let version = output
.stdout
.lines()
.filter(|l| !l.as_ref().unwrap().is_empty())
elizabethdinella marked this conversation as resolved.
Show resolved Hide resolved
.last()
.ok_or_else(|| SolcError::solc("version not found in solc output"))?
.map_err(|err| SolcError::msg(format!("Failed to read output: {err}")))?;
Expand Down