fix(core): re-export CallLogFrame from geth types #2283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CallLogFrame was not being exported from geth which made it difficult to store all the logs using the ethers type.
mattsse
approved these changes
Mar 20, 2023
DaniPopes
requested changes
Mar 20, 2023
The previous diff made the struct public but did not change the fields itself. The struct being public is not useful unless the fields are public.
|
Was just testing this locally and realized I didn't make the internal fields public. Fixed and good to go now! |
prestwich
approved these changes
Mar 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The CallLogFrame was not being exported from geth which made it
difficult to store all the logs using the ethers type.
Solution
Export CallLogFrame so it's accessible publicly via
ethers::types.Also export the internal fields.