Skip to content

Commit

Permalink
fix(core): re-export CallLogFrame from geth types (#2283)
Browse files Browse the repository at this point in the history
* fix(core): re-export CallLogFrame from geth types

The CallLogFrame was not being exported from geth which made it
difficult to store all the logs using the ethers type.

* fix(core): correct the visibility of the geth CallLogFrame struct

The previous diff made the struct public but did not change the fields
itself. The struct being public is not useful unless the fields are
public.
  • Loading branch information
jqphu committed Mar 21, 2023
1 parent 279280c commit 89cf65f
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion ethers-core/src/types/trace/geth.rs
Expand Up @@ -4,7 +4,7 @@ mod noop;
mod pre_state;

pub use self::{
call::{CallConfig, CallFrame},
call::{CallConfig, CallFrame, CallLogFrame},
four_byte::FourByteFrame,
noop::NoopFrame,
pre_state::{PreStateConfig, PreStateFrame},
Expand Down
6 changes: 3 additions & 3 deletions ethers-core/src/types/trace/geth/call.rs
Expand Up @@ -32,11 +32,11 @@ pub struct CallFrame {
#[derive(Debug, Clone, Default, PartialEq, Eq, Serialize, Deserialize)]
pub struct CallLogFrame {
#[serde(default, skip_serializing_if = "Option::is_none")]
address: Option<Address>,
pub address: Option<Address>,
#[serde(default, skip_serializing_if = "Option::is_none")]
topics: Option<Vec<H256>>,
pub topics: Option<Vec<H256>>,
#[serde(default, skip_serializing_if = "Option::is_none")]
data: Option<Bytes>,
pub data: Option<Bytes>,
}

#[derive(Debug, Clone, Default, PartialEq, Eq, Serialize, Deserialize)]
Expand Down

0 comments on commit 89cf65f

Please sign in to comment.