fix: feature resolution #2274
Merged
fix: feature resolution #2274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you check by pinning ethers = { git = "https://github.com/danipopes/ethers-rs", branch = "fix/feature-resolution" } |
mattsse
approved these changes
Mar 16, 2023
| @@ -58,6 +58,8 @@ default-members = [ | |||
| "ethers-solc", | |||
| ] | |||
|
|
|||
| resolver = "2" | |||
There was a problem hiding this comment.
TIL
https://doc.rust-lang.org/edition-guide/rust-2021/default-cargo-resolver.html
so if the crate does not use edition 2021 it falls back to old resolver unless the dependency uses resolver 2?
man I wonder how much time will be wasted on debugging problems this is causing
There was a problem hiding this comment.
Oh yeah there it is, virtual workspaces default to v1. Crazy
that works! ty |
|
works for me as well, thanks! |
gakonst
approved these changes
Mar 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes #2271
Fixes #2273
Solution
Explicitly specify
resolver = "2"in the workspaceAdd missing features which were getting wrongly compiled in due to resolver defaulting to "1"
PR Checklist