fix(core): properly parse genesis alloc storage #2205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Previously we were not properly parsing the storage field of GenesisAlloc. The first issue was in using serde(flatten), which is just incorrect because storage is not encoded flattened. The second issue was in the parsing of H256 keys and values. Some of the storage values in hive genesis examples were encoded in less than 64 hex characters, such as the string `0x12`. This would not succeed normal H256 parsing. * Introduce from_unformatted_hex_map to properly deserialize the storage map. * Modify existing genesis parsing tests to check parsed storage and code values against expected values. * Introduce new genesis parsing test from the hive smoke tests, checking full struct equality.
gakonst
approved these changes
Feb 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Previously we were not properly parsing the storage field of GenesisAlloc. The first issue was in using
serde(flatten), which is just incorrect because storage is not encoded flattened. The second issue was in the parsing ofH256keys and values. Some of the storage values in hive genesis examples were encoded in less than 64 hex characters, such as the string0x22. This would not succeed normal H256 parsing, but is consistent with JSON-RPC unformatted encoding.Solution
from_unformatted_hex_mapto properly deserialize the storage map.PR Checklist