fix(core): test hive genesis parsing #2145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gakonst
approved these changes
Feb 14, 2023
Comment on lines
+47
to
+64
|
|
||
| // The following fields are only included for tests, and should not be used in real genesis | ||
| // blocks. | ||
| /// The block number | ||
| #[serde(skip_serializing_if = "Option::is_none", default)] | ||
| pub number: Option<U64>, | ||
|
|
||
| /// The block gas gasUsed | ||
| #[serde(skip_serializing_if = "Option::is_none", default)] | ||
| pub gas_used: Option<U64>, | ||
|
|
||
| /// The block parent hash | ||
| #[serde(skip_serializing_if = "Option::is_none", default)] | ||
| pub parent_hash: Option<H256>, | ||
|
|
||
| /// The base fee | ||
| #[serde(skip_serializing_if = "Option::is_none", default)] | ||
| pub base_fee_per_gas: Option<U256>, |
There was a problem hiding this comment.
I would consider putting this in a hive: HiveParams w/ serde(flatten) but we can leave for follow-up, we don't use the genesis type in other places either way
There was a problem hiding this comment.
ah, yeah that makes sense
|
CI issues unrelated |
This was referenced Feb 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Hive tests require parsing many different geth
genesis.jsons. This adds tests for deserializing many of the genesis files contained in the hive test suite, revealing that we don't correctly parse all of them.TODO:
Solution
Use
serde(default)for all required genesis fields, and add genesis test fields from geth toGenesis.Support both hex and decimal decoding for
GenesisAllocfields.PR Checklist