Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed issue#2004 parsing solc verison with trailing newlines #2005

Merged
merged 2 commits into from Jan 13, 2023

Conversation

elizabethdinella
Copy link
Contributor

fixes #2004

Need some guidance on creating test(s) and updating docs

PR Checklist

  • Added Tests
  • Added Documentation
  • Updated the changelog
  • Breaking changes

ethers-solc/src/compile/mod.rs Outdated Show resolved Hide resolved
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, tysm!

@gakonst gakonst merged commit 0841e9b into gakonst:master Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ethers-solc version parsing fails with newline suffix
3 participants