-
-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Option to configure require-param
to work identical to pre - v25
#530
Comments
require-param
to work identical to v25 require-param
to work identical to pre - v25
…nd optional `inlineCommentBlock` property; fixes part of gajus#530 `inlineCommentBlock` will cause the fixer to insert an inline jsdoc block instead of the regular multiline, indented block.
I went for just the bonus points for now. :-) While you could already use (Sorry, @gajus , forgot to add this one as a PR first.) I intend to look next into disabling only the destructured property fixing. |
Btw, I realized we ought to be able to avoid the fixing of duplicates on |
wow!!!! unreal turnaround this is so amazing <3 can't wait to check this out! |
🎉 This issue has been resolved in version 25.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
To start off, I've really loved this plugin and especially the
require-param
rule. This has been great for enforcing consistency of docs on our team!Our codebase is entirely typescript so we set
'jsdoc/require-param-type': 0,
but leave onjsdoc/require-param
since it will enforce that each function param has an associated comment which is HUGE.The
v25
major upgrade however caused some problems since every object param we had was automatically expanded to have theopts.arg1
,opts.arg2
docs.We practically never want this expansion to happen because all of these object params have an associated typescript type, and we use tslint
completed-docs
to enforce each param in our typescript types has a comment.My Ask:
Is there a way that we can configured
require-param
to never do the automatic expansion of object params? I read the changelog and read the updated docs but I could not for the life of me figure out how to configure the eslint rules so that it never expanded, but still auto fixed to add a jsdoc for the arugment if it was missing. The old setup was so perfect and I 🙏 that there's a way to configure this to keep fix on but to not warn or fix this object expansionBonus Points:
Also trying to move off of tslint and finding a full replacement for the
completed-docs
rule is really hard. We like to write out types like the following:And the
completed-docs
rule can enforce that each of the type params (i.e.constants
,enums
,helpers
has an inline jsdoc). I could see this being outside the scope of this pacakge, but would be incredible if that capability was done here in eslint and not tslint!The text was updated successfully, but these errors were encountered: