Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash after upgrading from v24.0.6 #536

Closed
jaydenseric opened this issue May 12, 2020 · 3 comments
Closed

Crash after upgrading from v24.0.6 #536

jaydenseric opened this issue May 12, 2020 · 3 comments
Labels

Comments

@jaydenseric
Copy link
Contributor

Something changed between v24.0.6 and v25.0.0 to cause this exception:

Oops! Something went wrong! :(

ESLint: 7.0.0

Error: Unsupported function signature format.
Occurred while linting /[redacted]/graphql-react/src/universal/GraphQL.js:139
    at getParamName (/[redacted]/graphql-react/node_modules/eslint-plugin-jsdoc/dist/jsdocUtils.js:173:11)
    at /[redacted]/graphql-react/node_modules/eslint-plugin-jsdoc/dist/jsdocUtils.js:129:16
    at Array.map (<anonymous>)
    at getParamName (/[redacted]/graphql-react/node_modules/eslint-plugin-jsdoc/dist/jsdocUtils.js:128:32)
    at /[redacted]/graphql-react/node_modules/eslint-plugin-jsdoc/dist/jsdocUtils.js:177:12
    at Array.map (<anonymous>)
    at Object.getFunctionParameterNames (/[redacted]/graphql-react/node_modules/eslint-plugin-jsdoc/dist/jsdocUtils.js:176:30)
    at Object.utils.getFunctionParameterNames (/[redacted]/graphql-react/node_modules/eslint-plugin-jsdoc/dist/iterateJsdoc.js:182:32)
    at _default.meta.fixable (/[redacted]/graphql-react/node_modules/eslint-plugin-jsdoc/dist/rules/checkParamNames.js:199:40)
    at iterate (/[redacted]/graphql-react/node_modules/eslint-plugin-jsdoc/dist/iterateJsdoc.js:491:3)

Here is the doclet it has a problem with:

https://github.com/jaydenseric/graphql-react/blob/1bb884d0a9043f84727291c8580ab91fdc9ff196/src/universal/GraphQL.js#L139

@gajus
Copy link
Owner

gajus commented May 12, 2020

🎉 This issue has been resolved in version 25.2.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@gajus gajus added the released label May 12, 2020
@brettz9
Copy link
Collaborator

brettz9 commented May 12, 2020

This has now been fixed.

However, until #530 may be fixed, note that you will not have the option of disabling the now reporting of destructured params (in your case, fetchOptions.url and fetchOptions.options). PR #532 is mostly ready to request this ability to disable; will see about finishing up the necessary work tomorrow.

@brettz9
Copy link
Collaborator

brettz9 commented May 12, 2020

Feel free to subscribe to #530 for updates (though the title is for require-param, it also relates to check-param-names).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants