Update dependencies (including compatibility with css-loader v4) #298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
P.S.: No guarantees the update actually clones the nodes everywhery it is needed. cloneNode(..) statements were added to the spots which were detected by current tests, and no further efforts were taken to investigate the rest of code.
NodeJS 12.x version
…er library This change is necessary because the latest release, css-loader@5.0.0, closes the opportunity to access its default class name generation function. Thus, the necessary code is copy/pasted directly into this library. It should introduce no changes in the actual class name generation algo.
Bumps [node-notifier](https://github.com/mikaelbr/node-notifier) from 8.0.0 to 8.0.2. - [Release notes](https://github.com/mikaelbr/node-notifier/releases) - [Changelog](https://github.com/mikaelbr/node-notifier/blob/master/CHANGELOG.md) - [Commits](mikaelbr/node-notifier@v8.0.0...v8.0.2) Signed-off-by: dependabot[bot] <support@github.com>
…notifier-8.0.2 chore(deps): bump node-notifier from 8.0.0 to 8.0.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am not the author of this fork credits to @birdofpreyru.
I am creating this PR to get the ball rolling on the compatibility with css-loader v4
EDIT: unfortunately, as I am not the owner of the fork, I cannot fix the merge conflicts. If requested, I can fork @birdofpreyru's fork to fix those.