Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Allow different shell for post #10

Merged
merged 10 commits into from Jun 16, 2023
Merged

Feat: Allow different shell for post #10

merged 10 commits into from Jun 16, 2023

Conversation

hummeltech
Copy link
Contributor

Description

Sometimes it can be helpful to use a different shell for the post action, this adds in support for that.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas

@tarampampam
Copy link
Collaborator

tarampampam commented Jun 16, 2023

Could you update the readme file too?

@tarampampam tarampampam changed the title Fix: Allow different shell for post Feat: Allow different shell for post Jun 16, 2023
@hummeltech
Copy link
Contributor Author

Sure thing, good idea! I was thinking about doing that this morning too.

@tarampampam
Copy link
Collaborator

tarampampam commented Jun 16, 2023

Thank you very much! Could you please describe a situation where you may need to override the post-action shell?

@hummeltech
Copy link
Contributor Author

Sure, here are a few situations.

  • If you are using Windows, you might want to use PowerShell for the post command(s) and Bash for the run command(s).
  • If there is something that cannot be done with Bash for the run command(s), but you do want to use it for the post command(s), you could use Python for the run command(s)
    • Maybe you want to check that a database migration has completed (I.E. check if a table exists in the database)
  • If you are using a custom Docker image that has multiple shells that you want to test

Copy link
Member

@jetexe jetexe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!
There is one interesting moment

src/common.js Outdated Show resolved Hide resolved
src/common.js Outdated Show resolved Hide resolved
src/common.js Outdated Show resolved Hide resolved
hummeltech and others added 3 commits June 16, 2023 09:20
Co-authored-by: Pаramtamtām <7326800+tarampampam@users.noreply.github.com>
Co-authored-by: Pаramtamtām <7326800+tarampampam@users.noreply.github.com>
@hummeltech
Copy link
Contributor Author

No problem, thanks for the suggestions

@tarampampam
Copy link
Collaborator

LGTM @jetexe

Copy link
Member

@jetexe jetexe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for PR!

@jetexe jetexe merged commit 3618165 into gacts:main Jun 16, 2023
@jetexe
Copy link
Member

jetexe commented Jun 16, 2023

Released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants