Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added timezone argument to run and create #579

Merged
merged 4 commits into from
Apr 18, 2024

Conversation

tjd78
Copy link
Contributor

@tjd78 tjd78 commented Apr 17, 2024

  • Added tz to the arguments for run() and create() as per the arguments supported in podman:
    https://docs.podman.io/en/stable/markdown/podman-create.1.html#tz-timezone
  • This appears to be a podman only cli argument, but is very useful e.g. to ensure the container runs to match the host's timezone.
  • Added podman only testcases to demonstrate the change working as expected.

@LewisGaul
Copy link
Collaborator

@gabrieldemarmiesse did you want to have a look? Should be pretty uncontroversial :)

Copy link
Owner

@gabrieldemarmiesse gabrieldemarmiesse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, we can merge this. I would be open to accept in the future a PR to accept datetime.timezone as a valid argument for "tz". Of course str and None should always be accepted.

Thank you @LewisGaul for driving the code review!

@gabrieldemarmiesse gabrieldemarmiesse merged commit de46667 into gabrieldemarmiesse:master Apr 18, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants