Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support podman's --preserve-fds arg to container run/exec #576

Merged
merged 5 commits into from
Apr 12, 2024
Merged

Support podman's --preserve-fds arg to container run/exec #576

merged 5 commits into from
Apr 12, 2024

Conversation

LewisGaul
Copy link
Collaborator

@LewisGaul LewisGaul commented Apr 8, 2024 •
edited

Tested manually, but should probably add a testcase too... need to figure out the best way to do so.

  • Add testcase

@LewisGaul LewisGaul marked this pull request as ready for review April 8, 2024 22:25
gabrieldemarmiesse
gabrieldemarmiesse requested changes Apr 10, 2024
View reviewed changes
Copy link
Owner

@gabrieldemarmiesse gabrieldemarmiesse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pull request. I'm not super familiar with file descriptors. I guess we can assume that a reader knows they're represented by integers. We should just add a few comments here and there to explain the magic numbers and we should be good to go

python_on_whales/components/container/cli_wrapper.py Outdated Show resolved Hide resolved
python_on_whales/components/container/cli_wrapper.py Show resolved Hide resolved
tests/python_on_whales/components/test_container.py Show resolved Hide resolved
gabrieldemarmiesse
gabrieldemarmiesse approved these changes Apr 12, 2024
View reviewed changes
Copy link
Owner

@gabrieldemarmiesse gabrieldemarmiesse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, a high quality PR once again :)

@gabrieldemarmiesse gabrieldemarmiesse merged commit 0a9edc5 into gabrieldemarmiesse:master Apr 12, 2024
35 checks passed
@LewisGaul LewisGaul deleted the LG-preserve-fds branch April 12, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabrieldemarmiesse gabrieldemarmiesse gabrieldemarmiesse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@LewisGaul @gabrieldemarmiesse