Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the streaming of the docker.compose.pull logs #497

Merged
merged 1 commit into from Nov 11, 2023

Conversation

HemaZ
Copy link
Contributor

@HemaZ HemaZ commented Nov 11, 2023

same as #496 but for compose.pull. The test will most probably fail but i couldn't run it locally. having some problem with the docker registry, so hopefully it will run on github action and i will update it to the expected output

@HemaZ
Copy link
Contributor Author

HemaZ commented Nov 11, 2023

oh so it seems the docker hub issue is a problem with docker hub itself.
https://www.dockerstatus.com/

@gabrieldemarmiesse
Copy link
Owner

Indeed I had the same issue. Dockerhub seems to be having a bad time

@HemaZ HemaZ marked this pull request as ready for review November 11, 2023 22:51
@HemaZ
Copy link
Contributor Author

HemaZ commented Nov 11, 2023

Indeed I had the same issue. Dockerhub seems to be having a bad time

I think it got fixed. This passes now

Copy link
Owner

@gabrieldemarmiesse gabrieldemarmiesse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for the pull request! You're the 50th contributor of Python-on-whales! Sadly I don't have any prize, but you can be proud to add another cool feature to the lib that many users will appreciate!

@gabrieldemarmiesse gabrieldemarmiesse merged commit 3599854 into gabrieldemarmiesse:master Nov 11, 2023
36 checks passed
@HemaZ
Copy link
Contributor Author

HemaZ commented Nov 11, 2023

Many thanks for the pull request! You're the 50th contributor of Python-on-whales! Sadly I don't have any prize, but you can be proud to add another cool feature to the lib that many users will appreciate!

Thank you for creating this amazing project. It saved me a lot of time and i really appreciate it.

@gabrieldemarmiesse
Copy link
Owner

gabrieldemarmiesse commented Nov 12, 2023

I'm happy to hear it! The nice words of people like you are a good reason for me to work on this library :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants