This repository has been archived by the owner on May 17, 2019. It is now read-only.
Prevent tree-shaking of required polyfills #477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ganemone
approved these changes
Aug 20, 2018
gergelyke
approved these changes
Aug 20, 2018
|
!merge |
rtsao
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
assumeNoImportSideEffectsis set totrue, then imports for side effects will be tree-shaken (per webpack/webpack#6571 effectful imports are not considered side effect free by webpack).Because the API of core-js relies on import side effects (rather than some actual polyfill method) this means polyfills are erroneously never included.
This PR avoids this behavior by changing the polyfill imports to use
requireinstead.