Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return ErrClosed on Add() when the watcher is closed #516

Merged
merged 1 commit into from Oct 13, 2022
Merged

Return ErrClosed on Add() when the watcher is closed #516

merged 1 commit into from Oct 13, 2022

Commits on Oct 13, 2022

  1. Return ErrClosed on Add() when the watcher is closed 

    Also consistently return nil for Remove() and WatchList(). For Remove()
we could return an error, but I don't really see the point: if the
watcher is closed it's basically a no-op so returning nil is fine.

For WatchList() I'd like to return an error, but there is no error
return, so explicitly returning nil is the best we can do.

Fixes #511
    @arp242
    arp242 committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    f8aebb4 View commit details
    Browse the repository at this point in the history