Skip to content

Commit

Permalink
Actually, just return the first error
Browse files Browse the repository at this point in the history 
Now I got thousands of:

    helpers_test.go:384: fsnotify.readEvents: bad file descriptor
    helpers_test.go:384: fsnotify.readEvents: bad file descriptor
    helpers_test.go:384: fsnotify.readEvents: bad file descriptor
    helpers_test.go:384: fsnotify.readEvents: bad file descriptor
    helpers_test.go:384: fsnotify.readEvents: bad file descriptor
    helpers_test.go:384: fsnotify.readEvents: bad file descriptor
    helpers_test.go:384: fsnotify.readEvents: bad file descriptor
    helpers_test.go:384: fsnotify.readEvents: bad file descriptor
    helpers_test.go:384: fsnotify.readEvents: bad file descriptor
    helpers_test.go:384: fsnotify.readEvents: bad file descriptor
    helpers_test.go:384: fsnotify.readEvents: bad file descriptor
    helpers_test.go:384: fsnotify.readEvents: bad file descriptor
    helpers_test.go:384: fsnotify.readEvents: bad file descriptor
    helpers_test.go:384: fsnotify.readEvents: bad file descriptor
    helpers_test.go:384: fsnotify.readEvents: bad file descriptor
    helpers_test.go:384: fsnotify.readEvents: bad file descriptor
    helpers_test.go:384: fsnotify.readEvents: bad file descriptor

That's not helpful.
  • Loading branch information
@arp242
arp242 committed Oct 15, 2022
1 parent d284250 commit 06c044b
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions helpers_test.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -382,6 +382,8 @@ func (w *eventCollector) collect(t *testing.T) {
return
}
t.Error(e)
w.done <- struct{}{}
return
case e, ok := <-w.w.Events:
if !ok {
w.done <- struct{}{}
Expand Down

0 comments on commit 06c044b

Please sign in to comment.