Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Method to add service_name to all spans #34

Merged
merged 7 commits into from
May 3, 2021
Merged

Commits on Apr 6, 2021

  1. Method to add service_name to all spans

    It's useful to have a way to set the service name for all spans at once,
    rather than having to set it every time.
    
    This commit adds a with_service_name method to PipelineBuilder
    and Exporter to allow users to set the service name in one place,
    following the behaviour of the official DataDog and Zipkin exporters.
    
    It also sets a default service_name if the user does not configure one.
    isobelhooper committed Apr 6, 2021
    Configuration menu
    Copy the full SHA
    dc21605 View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2021

  1. Set service.name through sdk::Resource

    Rather than relying on a property on PipelineBuilder, instead set the
    service.name in the sdk::Config by merging sdk::Resouce properties. This
    is also a change to the behavior of with_config.
    johnchildren committed Apr 29, 2021
    Configuration menu
    Copy the full SHA
    e867045 View commit details
    Browse the repository at this point in the history
  2. Remove unnecessary assignment

    Co-authored-by: isobelhooper <isobel.hooper@cambridgequantum.com>
    johnchildren and isobelhooper committed Apr 29, 2021
    Configuration menu
    Copy the full SHA
    3f2a02b View commit details
    Browse the repository at this point in the history
  3. Fix compilation errors

    johnchildren committed Apr 29, 2021
    Configuration menu
    Copy the full SHA
    cc3269e View commit details
    Browse the repository at this point in the history
  4. Convert name for value

    johnchildren committed Apr 29, 2021
    Configuration menu
    Copy the full SHA
    7590ab7 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    ea40a01 View commit details
    Browse the repository at this point in the history
  6. Merge pull request #1 from johnchildren/service-name-through-config

    Set service.name through sdk::Resource
    isobelhooper committed Apr 29, 2021
    Configuration menu
    Copy the full SHA
    a581bc7 View commit details
    Browse the repository at this point in the history