-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove dependency on googleapis
#187
Conversation
fd16af4
to
c470b7a
Compare
c470b7a
to
048ffd0
Compare
Since this would a breaking change, marking it blocked until we release milestone v0.5.5. |
048ffd0
to
dd42a0a
Compare
We can also branch v0.5.x now and merge this to v0.x.x, but I'm fine with the approach that's the easiest for you. |
What I forgot to do, since this is a breaking, is to create a Also fixing the package name, I noticed a whole package for decimal might be too much and maybe we can make like google and have a types package, for example. I wanted to know your opinion before I update the PR. |
4a6dd13
to
2b4bba8
Compare
Thanks for being patient 🙏 I will get v0.5.5 out today. That would be easiest for me. We do not have upcoming non-breaking changes, so we can unblock this PR later today.
I'd suggest holding on to that idea until we have a stable v1.0. I think the upcoming release v0.6.0 is going to be our stable-release candidate.
I would prefer that as well. Also, we'd need to create a new directory |
Still, this will make it very messy to update again, we'll have to update everything at the same time or we won't be able to use python projects with mixed versions. My learning is, we should have probably called pre-release versions If this is really the only breaking change in v0.6.x, I guess it shouldn't be that bad, because I guess downstream projects can still depend on googleapis on their side. The wire format didn't really change. |
Yeah. that's exactly what I had in mind, will do that.
Ah, right, I thought I copied what |
2b4bba8
to
d00c1a0
Compare
Updated! |
Yeah, I feel so too. Missed opportunity.
No, there are quite a few in the milestone. |
d00c1a0
to
b630eb0
Compare
@tiyash-basu-frequenz done! |
Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
The dependency on `googleapis-common-protos` / `googleapis/googleapis` was removed, now that we have the internal `frequenz.api.common.decimal` we don't need the dependency anymore. Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
b630eb0
to
7109ddf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
To be able to do so we create a new
Decimal
message that is compatible with Google'sDecimal
message.Fixes #152.