Include the original test name in expired stub error messages #644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is currently very hard to track down such leaked stubs, when they happen, as they might be created in one test and cause an exception dozens of tests later. By including the name of the test that invalidated them, it makes the debugging process a bit easier. Note, I made `setup` also accept the current test instance purely for consistency with `teardown` but it's not strictly necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #641 and thanks to @casperisfine.
It is currently very hard to track down such leaked stubs, when they happen, as they might be created in one test and cause an exception dozens of tests later.
By including the name of the test that invalidated them, it makes the debugging process a bit easier.
Note, I made
setupalso accept the current test instance purely for consistency withteardownbut it's not strictly necessary.