WIP: First stab at addressing #614 #615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
However, in the If you remove that line from the |
floehopper
force-pushed
the
fix-minitest-compatibility
branch
from
0be64b2
to
7963680
Compare
It turns out we were relying on the very old [1] MiniTest module name rather than the newer Minitest module name. While there are other places in the code that use the MiniTest form, most (all?) of those are internal to Mocha. Anyway making this one change seems to fix the problems people are having. Ideally I'd like to add a failing test to force me to make this change, but I don't have time right now and I want to fix the problem for people as soon as possible. I've run this fix against a large test suite and the build passes [2], so it doesn't feel very risky releasing this. It would also be good to do a general clean up of all the uses of MiniTest to make sure I haven't missed anything. Fixes #614. [1]: https://github.com/minitest/minitest/blob/master/History.rdoc#505--2013-06-20- [2]: alphagov/whitehall#8015
floehopper
force-pushed
the
fix-minitest-compatibility
branch
from
7963680
to
32ef48f
Compare
|
@Maimer Ah, thank you - I haven't had much time to look at this closely, so that's really helpful! 🙏 |
floehopper
added a commit
that referenced
this pull request
Nov 12, 2023
As per this comment [1]. Thanks, @Maimer! As of Minitest v5.19.0 [2], there's no need to require this file. Also the Minitest version constant is now also available at the top-level, i.e. Minitest::VERSION, which seems like a more sensible place to get it from. [1]: #615 (comment) [2]: https://github.com/minitest/minitest/blob/f908dda892e70b0389c61c12137a18be8e3fb179/History.rdoc#label-5.19.0+-2F+2023-07-26
floehopper
added a commit
that referenced
this pull request
Nov 12, 2023
As per this comment [1]. Thanks, @Maimer! As of Minitest v5.19.0 [2], there's no need to require this file. [1]: #615 (comment) [2]: https://github.com/minitest/minitest/blob/f908dda892e70b0389c61c12137a18be8e3fb179/History.rdoc#label-5.19.0+-2F+2023-07-26
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: