Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: replace custom CLI parsers with ethers FromStr implementations #4349

Merged
merged 4 commits into from Feb 16, 2023
Merged

chore: replace custom CLI parsers with ethers FromStr implementations #4349

merged 4 commits into from Feb 16, 2023

Conversation

DaniPopes
Copy link
Member

@DaniPopes DaniPopes commented Feb 14, 2023 •
edited

Motivation

tg discussions, ref gakonst/ethers-rs#2095

current implementation contains a bug, fixed by: gakonst/ethers-rs#2155

Solution

remove parse_name_or_address and parse_block_id, which Clap defaults the parsing to use FromStr::from_str

@mattsse mattsse added the L-ignore Log: ignore PR in changelog label Feb 14, 2023
@mattsse
Copy link
Member

mattsse commented Feb 14, 2023

the failing test seems related?

@DaniPopes
Copy link
Member Author

the failing test seems related?

PR Description:

current implementation contains a bug, fixed by: gakonst/ethers-rs#2155

Regarding #4357, this PR removes the functions because they are implemented in ethers-rs with gakonst/ethers-rs#2095

mattsse
mattsse approved these changes Feb 15, 2023
View reviewed changes
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs an ethers bump to fix the bug mentioned, right?

@DaniPopes DaniPopes mentioned this pull request Feb 15, 2023
Merged
@gakonst gakonst merged commit 9317d19 into foundry-rs:master Feb 16, 2023
@DaniPopes DaniPopes deleted the chore/replace-cli-parsers branch February 16, 2023 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gakonst gakonst gakonst approved these changes

@mattsse mattsse mattsse approved these changes

Assignees
No one assigned
Labels
L-ignore Log: ignore PR in changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@DaniPopes @mattsse @gakonst