Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dep: solang parser 0.2.2 #4328

Merged
merged 10 commits into from
Feb 11, 2023
Merged

dep: solang parser 0.2.2 #4328

merged 10 commits into from
Feb 11, 2023

Conversation

rkrasiuk
Copy link
Collaborator

Motivation

Closes #4319

Solution

Upgrade solang-parser to 0.2.2
Add support for named mapping in forge formatter

Blocked by gakonst/ethers-rs#2135

@rkrasiuk rkrasiuk added C-forge Command: forge Cmd-forge-fmt Command: forge fmt labels Feb 10, 2023
@mattsse mattsse marked this pull request as ready for review February 11, 2023 10:29
@mattsse
Copy link
Member

mattsse commented Feb 11, 2023

I fixed breaking changes @rkrasiuk

only the MappingType test is failing:

https://github.com/foundry-rs/foundry/actions/runs/4150900741/jobs/7180964637

@rkrasiuk
Copy link
Collaborator Author

@mattsse the formatting of Type::Mapping needed to be refined

Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

smol lint issue,

can merge once CI passes

@rkrasiuk rkrasiuk merged commit 4604d20 into master Feb 11, 2023
@rkrasiuk rkrasiuk deleted the rkrasiuk/dep-solang-parser-0.2.2 branch February 11, 2023 16:32
@rkrasiuk rkrasiuk mentioned this pull request Feb 21, 2023
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-forge Command: forge Cmd-forge-fmt Command: forge fmt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Forge fmt fails for new solidity 0.8.18 named mappings
2 participants