build(deps): bump github.com/spf13/cobra from 1.7.0 to 1.8.0 #329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
dependabot
bot
force-pushed
the
dependabot/go_modules/github.com/spf13/cobra-1.8.0
branch
from
1781c62
to
91f79fc
Compare
|
We are specifically interested in this fix: https://redirect.github.com/spf13/cobra/issues/2044 I will try to do some regression testing later this week. |
|
@dependabot rebase |
Bumps [github.com/spf13/cobra](https://github.com/spf13/cobra) from 1.7.0 to 1.8.0. - [Release notes](https://github.com/spf13/cobra/releases) - [Commits](spf13/cobra@v1.7.0...v1.8.0) --- updated-dependencies: - dependency-name: github.com/spf13/cobra dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
force-pushed
the
dependabot/go_modules/github.com/spf13/cobra-1.8.0
branch
from
91f79fc
to
85e328e
Compare
|
Verified that the most critical cobra functions we use work well, and that the fix we need also works spf13/cobra#2044. |
vkhoroz
deleted the
dependabot/go_modules/github.com/spf13/cobra-1.8.0
branch
vkhoroz
added a commit
that referenced
this pull request
Nov 14, 2023
We upgraded cobra to 1.8.0 with #329. So we can use its fix for persistent hooks traversal spf13/cobra#2044, instead of our workaround for it from #312. Signed-off-by: Volodymyr Khoroz <volodymyr.khoroz@foundries.io>
vkhoroz
added a commit
that referenced
this pull request
Nov 14, 2023
We upgraded cobra to 1.8.0 with #329. So we can use its fix for persistent hooks traversal spf13/cobra#2044, instead of our workaround for it from #312. Signed-off-by: Volodymyr Khoroz <volodymyr.khoroz@foundries.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps github.com/spf13/cobra from 1.7.0 to 1.8.0.
Release notes
Sourced from github.com/spf13/cobra's releases.
Commits
a0a6ae0Improve API to get flag completion function (#2063)890302aSupport usage as plugin for tools like kubectl (#2018)48cea5cbuild(deps): bump actions/checkout from 3 to 4 (#2028)22953d8Replace all non-alphanumerics in active help env var program prefix (#1940)00b68a1Add tests for flag completion registration (#2053)b711e87Don't complete --help flag when flag parsing disabled (#2061)8b1eba4Fix linter errors (#2052)4cafa37Allow running persistent run hooks of all parents (#2044)5c962a2build(deps): bump github.com/cpuguy83/go-md2man/v2 from 2.0.2 to 2.0.3 (#2047)efe8fa3build(deps): bump actions/setup-go from 3 to 4 (#1934)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)