Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

15549487: Get rid of karma on yaem #102

Merged
merged 6 commits into from Sep 4, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
File renamed without changes.
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
Expand Up @@ -27,4 +27,4 @@ jobs:
cache: 'yarn'
- run: yarn install --frozen-lockfile
- run: yarn run lint
- run: xvfb-run yarn run test
- run: yarn run test
11 changes: 11 additions & 0 deletions jasmine.json
@@ -0,0 +1,11 @@
{
"spec_dir": "test",

"spec_files": [
"**/*.test.js"
],

"env": {
"failSpecWithNoExpectations": true
}
}
55 changes: 0 additions & 55 deletions karma.conf.js

This file was deleted.

18 changes: 7 additions & 11 deletions package.json
Expand Up @@ -2,12 +2,15 @@
"name": "yaem",
"version": "0.1.0",
"description": "Event manager",
"main": "index.js",
"type": "module",
"exports": {
".": "./index.js"
},
"author": "finsit",
"license": "MIT",
"scripts": {
"lint": "eslint --report-unused-disable-directives .",
"test": "karma start"
"test": "jasmine --config=jasmine.json"
},
"devDependencies": {
"@foretagsplatsen/eslint-plugin-ftgp": "^2.1.1",
Expand All @@ -18,14 +21,7 @@
"eslint-plugin-import": "^2.28.1",
"eslint-plugin-prettier": "^5.0.0",
"eslint-plugin-sort-class-members": "^1.18.0",
"jasmine": "^4.5.0",
"karma": "^6.4.2",
"karma-electron": "^7.3.0",
"karma-electron-launcher": "^0.3.0",
"karma-jasmine": "^5.1.0",
"karma-webpack": "^5.0.0",
"prettier": "^3.0.2",
"webpack": "^5.88.2",
"webpack-cli": "^5.1.4"
"jasmine": "^5.1.0",
"prettier": "^3.0.2"
}
}
2 changes: 1 addition & 1 deletion src/eventCategory.js
@@ -1,4 +1,4 @@
import event from "./event";
import event from "./event.js";

/**
* Keeps a list of events.
Expand Down
2 changes: 1 addition & 1 deletion src/eventManager.js
@@ -1,4 +1,4 @@
import eventCategory from "./eventCategory";
import eventCategory from "./eventCategory.js";

/**
* Singleton object that keeps a list of named event categories.
Expand Down
6 changes: 3 additions & 3 deletions test/events.test.js
@@ -1,6 +1,6 @@
import event from "../src/event";
import eventCategory from "../src/eventCategory";
import events from "../src/eventManager";
import event from "../src/event.js";
import eventCategory from "../src/eventCategory.js";
import events from "../src/eventManager.js";

describe("events", () => {
it("Bind callback to event", () => {
Expand Down