-
Notifications
You must be signed in to change notification settings - Fork 447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
L4 fixes #3179
Commits on Jun 21, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 023ad3a - Browse repository at this point
Copy the full SHA 023ad3aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7385cbb - Browse repository at this point
Copy the full SHA 7385cbbView commit details -
[instancer/L4] Further simplify
outGain is always zero in this branch.
Configuration menu - View commit details
-
Copy full SHA for 94e0816 - Browse repository at this point
Copy the full SHA 94e0816View commit details -
[instancer/L4] Fix normalizeValue for L4 solver
Imagine a font with current min/default/max of 100,700,1000. And new setting of 100,400,1000. The current normalizeLocation will calculate the new location for 700 to be +.33, whereas it should calculate +.5! This is because 400 translates to -.5, so 700 will be normalized to -1,-.5,+1 and get +.33... We need a special normalizeLocation that is aware of the "distance" between min/default/max, ie. the non-normalized values. Then it will be clear that the distance from 400 to 700 is equal to 700 to 1000, and as such 700 should be normalized to .5, not .33... I'm still trying to figure out the case where avar is present. Store this distance in NormalizeAxisLimit and reach it out in the solver. Fixes #3177
Configuration menu - View commit details
-
Copy full SHA for 72b6102 - Browse repository at this point
Copy the full SHA 72b6102View commit details -
Configuration menu - View commit details
-
Copy full SHA for 43e5aae - Browse repository at this point
Copy the full SHA 43e5aaeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 204532a - Browse repository at this point
Copy the full SHA 204532aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 17761cc - Browse repository at this point
Copy the full SHA 17761ccView commit details -
Configuration menu - View commit details
-
Copy full SHA for 10bc7a8 - Browse repository at this point
Copy the full SHA 10bc7a8View commit details
Commits on Jun 22, 2023
-
Configuration menu - View commit details
-
Copy full SHA for ddc484d - Browse repository at this point
Copy the full SHA ddc484dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 71cca00 - Browse repository at this point
Copy the full SHA 71cca00View commit details
Commits on Jul 11, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 0893ba9 - Browse repository at this point
Copy the full SHA 0893ba9View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.