Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

L4 fixes #3179

Merged
merged 11 commits into from
Jul 11, 2023
Merged

L4 fixes #3179

merged 11 commits into from
Jul 11, 2023

Commits on Jun 21, 2023

  1. Configuration menu
    Copy the full SHA
    023ad3a View commit details
    Browse the repository at this point in the history
  2. [instancer/L4] Simplify

    behdad committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    7385cbb View commit details
    Browse the repository at this point in the history
  3. [instancer/L4] Further simplify

    outGain is always zero in this branch.
    behdad committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    94e0816 View commit details
    Browse the repository at this point in the history
  4. [instancer/L4] Fix normalizeValue for L4 solver

    Imagine a font with current min/default/max of 100,700,1000. And new
    setting of 100,400,1000. The current normalizeLocation will calculate
    the new location for 700 to be +.33, whereas it should calculate +.5!
    This is because 400 translates to -.5, so 700 will be normalized to
    -1,-.5,+1 and get +.33...
    
    We need a special normalizeLocation that is aware of the "distance"
    between min/default/max, ie. the non-normalized values. Then it will be
    clear that the distance from 400 to 700 is equal to 700 to 1000, and as
    such 700 should be normalized to .5, not .33... I'm still trying to
    figure out the case where avar is present.
    
    Store this distance in NormalizeAxisLimit and reach it out in the
    solver.
    
    Fixes #3177
    behdad committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    72b6102 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    43e5aae View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    204532a View commit details
    Browse the repository at this point in the history
  7. [instancer/L4] Add tests

    behdad committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    17761cc View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    10bc7a8 View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2023

  1. [instancer/L4] Add a comment

    behdad committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    ddc484d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    71cca00 View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2023

  1. Configuration menu
    Copy the full SHA
    0893ba9 View commit details
    Browse the repository at this point in the history