Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop impliable oncurves either before or after rounding #3156

Merged
merged 6 commits into from
Jun 8, 2023

Commits on Jun 7, 2023

  1. Configuration menu
    Copy the full SHA
    f7ca9f2 View commit details
    Browse the repository at this point in the history
  2. ttGlyphPen: drop implied before rounding, allow not to round at all

    We want to be able to compute implied oncurves both before coordinates have been rounded to integer and afterwards.
    Also when ufo2ft builds interpolatable master TTFs, we want to turn off the rounding so that varLib can call dropImpliedOnCurvePoints on the un-rounded coordinates, so we need an option to disable rounding the coordinates in the ttGlyphPens
    anthrotype committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    97e626b View commit details
    Browse the repository at this point in the history
  3. _getCoordinatesAndControls: make sure coords are rounded toInt() as g…

    …var expects
    
    ufo2ft will no longer send varLib already-rounded master glyf tables (to give it an opportunity to compute implied oncurves on the pre-rounded coords) so when retrieving coordinates off the glyf table in order to compute gvar deltas we have to round
    anthrotype committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    1ca5543 View commit details
    Browse the repository at this point in the history
  4. drop oncurve if it's impliable either before OR after rounding

    ofter the rounding gives us an opportunity to make an oncurve impliable, for points that were not equidistant become so after round, so why not take it!
    anthrotype committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    8677752 View commit details
    Browse the repository at this point in the history

Commits on Jun 8, 2023

  1. Configuration menu
    Copy the full SHA
    5c0f05c View commit details
    Browse the repository at this point in the history
  2. glyf: use 'round' parameter in _getCoordinatesAndControls

    as Behdad suggested in review
    anthrotype committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    dfec4ab View commit details
    Browse the repository at this point in the history