Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[varlib] add --drop-implied-oncurves option #3147

Merged
merged 4 commits into from
Jun 5, 2023
Merged

[varlib] add --drop-implied-oncurves option #3147

merged 4 commits into from
Jun 5, 2023

Commits on Jun 2, 2023

  1. dropImpliedOnCurvePoints: raise if incompatible, skip empty/composites

    @anthrotype
    anthrotype committed Jun 2, 2023
    Configuration menu
    Copy the full SHA
    6a276d9 View commit details
    Browse the repository at this point in the history

  2. ttGlyphPen: only call dropImpliedOnCurvePoints for simple glyphs afte… 

    …r fully formed
    @anthrotype
    anthrotype committed Jun 2, 2023
    Configuration menu
    Copy the full SHA
    b6bb9df View commit details
    Browse the repository at this point in the history

  3. varLib: add --drop-implied-oncurves option 

    For the test, I used the Tests/varLib/data/Build.designspace as starting point, modified the 'a' glyph so that 1 on-curve point (the first one) becomes impliable for all the masters.
    @anthrotype
    anthrotype committed Jun 2, 2023
    Configuration menu
    Copy the full SHA
    0690703 View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2023

  1. also check endPtsOfContours in dropImpliedOnCurvePoints 

    as per review #3147 (comment)

Also, don't do same work multiple times when dropping points from flags/endPtsOfContours arrays since these are supposed to be the same for all interpolatable glyphs
    @anthrotype
    anthrotype committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    5b93100 View commit details
    Browse the repository at this point in the history