Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[varStore] Improve optimize algorithm #3124

Merged
merged 8 commits into from
May 24, 2023
Merged

[varStore] Improve optimize algorithm #3124

merged 8 commits into from
May 24, 2023

Commits on May 24, 2023

  1. [varStore] Improve optimize algorithm 

    This was always supposed to be how it works, but was missed in
the initial implementation apparently.
    @behdad
    behdad committed May 24, 2023
    Configuration menu
    Copy the full SHA
    6097b32 View commit details
    Browse the repository at this point in the history

  2. [varStore] Another fix to the optimize algorithm 

    Previously we were disregarding the best_gain. Ouch!
    @behdad
    behdad committed May 24, 2023
    Configuration menu
    Copy the full SHA
    5895417 View commit details
    Browse the repository at this point in the history

  3. [varStore] Document the optimize algorithm

    @behdad
    behdad committed May 24, 2023
    Configuration menu
    Copy the full SHA
    cdcbf64 View commit details
    Browse the repository at this point in the history

  4. [varStore] More documentation

    @behdad
    behdad committed May 24, 2023
    Configuration menu
    Copy the full SHA
    cb2f5aa View commit details
    Browse the repository at this point in the history

  5. [varStore] Add test for optimize() 

    Doesn't hit all branches yet.
    @behdad
    behdad committed May 24, 2023
    Configuration menu
    Copy the full SHA
    e4281b0 View commit details
    Browse the repository at this point in the history

  6. [varStore] Another bugfix in optimize()

    @behdad
    behdad committed May 24, 2023
    Configuration menu
    Copy the full SHA
    0677c0e View commit details
    Browse the repository at this point in the history

  7. [varStore] Adjust encoding overhead in optimize() 

    Previously we were not accounting for the LOffset to VarData.
    @behdad
    behdad committed May 24, 2023
    Configuration menu
    Copy the full SHA
    b72a8da View commit details
    Browse the repository at this point in the history

  8. [varStore] Add another test

    @behdad
    behdad committed May 24, 2023
    Configuration menu
    Copy the full SHA
    abe2a37 View commit details
    Browse the repository at this point in the history