Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[merge] Handle differing default/nominalWidthX in CFF #3070

Merged
merged 3 commits into from
Apr 19, 2023
Merged

[merge] Handle differing default/nominalWidthX in CFF #3070

merged 3 commits into from
Apr 19, 2023
+305 −285

Conversation

behdad
Copy link
Member

@behdad behdad commented Mar 29, 2023 •
edited
Loading

Fixes #3069

@behdad
[merge] Handle None GDEF.table.MarkGlyphSetsDef

Verified

This commit was signed with the committer’s verified signature.
MichaReiser Micha Reiser
SSH Key Fingerprint: ecGsN1ElBc6rDn4Ge3zV90y0fffKRH+1PNbJCxfpPEs
Verified
Learn about vigilant mode
cc2f667
@behdad behdad mentioned this pull request Mar 29, 2023
Closed
@behdad
Copy link
Member Author

behdad commented Mar 29, 2023

The test expectation rightly needs to be updated IMO.

@behdad
[merge] Handle differing CFF nominal/defaultWidthX

Verified

This commit was signed with the committer’s verified signature.
MichaReiser Micha Reiser
SSH Key Fingerprint: ecGsN1ElBc6rDn4Ge3zV90y0fffKRH+1PNbJCxfpPEs
Verified
Learn about vigilant mode
b073b06 
Fixes #3069
@behdad behdad changed the title Merge [merge] Handle differing default/nominalWidthX in CFF Mar 29, 2023
@behdad behdad requested a review from anthrotype March 29, 2023 18:44
@KatjaSchimmel
Copy link

Hi! I was just wondering if this will be merged soon. I am looking forward to testing it

anthrotype
anthrotype approved these changes Apr 19, 2023
View reviewed changes
Copy link
Member

@anthrotype anthrotype left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

belated LGTM!

@behdad @anthrotype
Update Lib/fontTools/merge/tables.py

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
3d94c6d 
Co-authored-by: Cosimo Lupo <clupo@google.com>
@behdad behdad merged commit 57c7792 into main Apr 19, 2023
@behdad behdad deleted the merge branch April 19, 2023 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anthrotype anthrotype

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pyftmerge OTF changes width of glyphs in output file
3 participants
@behdad @KatjaSchimmel @anthrotype