Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

privData needs to padded with bytes not str #3129

Merged
merged 4 commits into from May 30, 2023
Merged

privData needs to padded with bytes not str #3129

merged 4 commits into from May 30, 2023

Conversation

benkiel
Copy link
Collaborator

@benkiel benkiel commented May 25, 2023 •
edited

One letter, but an important one.

@behdad
Copy link
Member

behdad commented May 25, 2023

How did this ever work?!

@anthrotype
Copy link
Member

ouch. thanks

looks like this wasn't covered by tests. Mind adding a simple one somewhere?

@anthrotype
Copy link
Member

How did this ever work?!

it didn't 😅

@benkiel
Copy link
Collaborator Author

benkiel commented May 25, 2023

@anthrotype in the middle of trying to get out a font release, tbh. Will try to come back and make a test later this week

@benkiel benkiel changed the title privData needs to pad with bytes not str privData needs to padded with bytes not str May 25, 2023
@benkiel
Copy link
Collaborator Author

benkiel commented May 27, 2023

@anthrotype where would be best to put a test?

I can see either putting it in main_test.py for ttLib or in sfnt_test.py — the first is easier as it already has methods for getting a font object to use, and it tests WOFF a bit already, but the direct place is sfnt_test.py. (yes, there could also be woff_test.py but that's the most work.

@anthrotype
Copy link
Member

Where it's more convenient to you, any test is better than nothing thanks

@benkiel
Copy link
Collaborator Author

benkiel commented May 28, 2023

@anthrotype ok, test added

@benkiel benkiel added the bug label May 29, 2023
@benkiel
Copy link
Collaborator Author

benkiel commented May 29, 2023

Ok to merge?

anthrotype
anthrotype approved these changes May 30, 2023
View reviewed changes
Copy link
Member

@anthrotype anthrotype left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@anthrotype anthrotype merged commit 0bf84f9 into main May 30, 2023
10 checks passed
@anthrotype anthrotype deleted the privData_bytes branch May 30, 2023 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anthrotype anthrotype anthrotype approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@benkiel @behdad @anthrotype