Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ci): upgrade unicorn to 46 to fix eslint 8.40 #2780

Merged
merged 1 commit into from
May 8, 2023
Merged

fix(ci): upgrade unicorn to 46 to fix eslint 8.40 #2780

merged 1 commit into from
May 8, 2023

Conversation

lubber-de
Copy link
Member

Description

Recent eslint 8.40 brokein ci, because of
sindresorhus/eslint-plugin-unicorn#2076

TypeError: Cannot read properties of undefined (reading 'getAllComments')
Occurred while linting /home/runner/work/Fomantic-UI/Fomantic-UI/.eslint/eqeqeq-rule.js:1
Rule: "unicorn/expiring-todo-comments"

Fixes

#2779

@lubber-de lubber-de added type/ci Anything related to CI/CD dependencies Pull requests that update a dependency file labels May 8, 2023
@lubber-de lubber-de added this to the 2.9.3 milestone May 8, 2023
@lubber-de lubber-de merged commit eb16c99 into develop May 8, 2023
16 checks passed
@lubber-de lubber-de deleted the unicorn46upgrade branch May 8, 2023 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ko2in ko2in Awaiting requested review from ko2in

@ColinFrick ColinFrick Awaiting requested review from ColinFrick

@prudho prudho Awaiting requested review from prudho

@y0hami y0hami Awaiting requested review from y0hami

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file type/ci Anything related to CI/CD
Projects
None yet
Milestone
2.9.3
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@lubber-de