Re-instantiate non-optimized clone fallback #1126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiddeco
commented
Jun 23, 2023
hiddeco
force-pushed
the
fix-optimized-clone
branch
from
0fc40c1
to
7d392b8
Compare
hiddeco
changed the title
hiddeco
force-pushed
the
fix-optimized-clone
branch
2 times, most recently
from
f693d7c
to
7d392b8
Compare
This adds a bit back which got removed in 69f567b, as there are reasons for the controller to perform a non-optimized clone. However, we always want to attempt the optimized version first without it being put behind a feature gate. Which was the original intent of the referenced commit. Signed-off-by: Hidde Beydals <hidde@hhh.computer>
hiddeco
force-pushed
the
fix-optimized-clone
branch
2 times, most recently
from
3cc2f27
to
b79fe22
Compare
This is required because the test fails with Git >=v2.41.0 due to changes to commands used by the Git test server. Causing the server to return an error when cloning an empty repository, instead of yielding an empty object. Signed-off-by: Hidde Beydals <hidde@hhh.computer>
hiddeco
force-pushed
the
fix-optimized-clone
branch
from
b79fe22
to
60571c0
Compare
|
This appears to actually be related to go-git/go-git#802 |
|
I would concur with the above. And would use the pseudo version from master until a go-git release is cut - which will take a few weeks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a bit back which got removed in
69f567b, as there are reasons for the controller to perform a non-optimized clone.
However, we always want to attempt the optimized version first without it being put behind a feature gate. Which was the original intent of the referenced commit.