fix various typos #5761
Merged
fix various typos #5761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
since the typo checker missed some of these, maybe time to update version? mentioned these in upstream crate-ci to get em there eventually. crate-ci/typos#943 |
|
Pushed some more fixes here and rebased on current master. |
|
Ok, additionally updated the typos checker version as suggested by @chu11 (and added one more file to the exclusions) |
|
I would add an approval but as the originator of this PR I'm not allowed :-( |
grondo
approved these changes
Mar 5, 2024
Problem: some comments in cmd/builtin/relay.c have typos. Fix the typos.
Problem: a comment in topo.c states that XML is reduced along with R_local, however this is not true. XML is no longer reduced since flux-framework#4263 (in flux-core-0.39.0). Drop that part of the comment.
Problem: a stray asterisk appears in a reslog.h block comment. Remove it.
Problem: a comment in boot_pmi.c misspells "independently". Fix spelling.
Problem: A NEWS item in NEWS.md say 'udate' instead of 'update.' Fix the typo.
Problem: A release note from v0.5.0 calls out a single typo fix causing the typos checker to fail on this file. It is probably ok not to mention the exact typo that was fixed, so shorten and simplify the release note as opposed to adding an individual exclusion to the checks.
Problem: A comment in src/cmd/flux-module.c has a typo. Fix the typo.
Problem: A comment in t0005-exec.t contains a typo. Fix the typo.
Problem: A test in t2110-job-ingest-validator.t contains a typo in the test description. Fix the typo.
Problem: The crate-ci/typos action is out of date. Update the typos checker to v0.19.0. Add src/common/libutil/test/blobref.c to the set of excluded files since it contains some hash strings which generate false positives.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #5761 +/- ##
==========================================
+ Coverage 83.29% 83.31% +0.01%
==========================================
Files 509 509
Lines 82425 82425
==========================================
+ Hits 68660 68669 +9
+ Misses 13765 13756 -9
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The obligatory typo fix PR. Feel free to push here.