Add pub ignore comment to devtools extensions readme #6467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenzieschmoll
requested review from
CoderDake
and removed request for
a team
polina-c
approved these changes
Sep 25, 2023
jonasfj
reviewed
Sep 26, 2023
| of your pub package: | ||
|
|
||
| ``` | ||
| !./extension/devtools/build |
There was a problem hiding this comment.
@kenzieschmoll
When you put a .pubignore at the root, then the root .gitignore won't be considered at all.
So that might be undesirable... or at least the user will have to duplicate patterns they want in both.
A better option could be to do extensions/devtools/.pubignore that way it's only for the extensions/devtools/.
It won't pollute root, and most likely there is no .gitignore in extensions/devtools anyways.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding this based on a recommendation from @rrousselGit here. Addressed for
package:providerin rrousselGit/provider@25a7e18.FYI @jonasf - do you see any issues with this recommended use of the
.pubignorefile?