Run tests under .NET 8

[vbreuss]

Discussion in #2465

Enable tests to run under .NET 8.

IMPORTANT

• If the PR touches the public API, the changes have been approved in a separate issue with the "api-approved" label.
• The code complies with the Coding Guidelines for C#.
• The changes are covered by unit tests which follow the Arrange-Act-Assert syntax and the naming conventions such as is used in these tests.
• If the PR adds a feature or fixes a bug, please update the release notes with a functional description that explains what the change means to consumers of this library, which are published on the website.
• If the PR changes the public API the changes needs to be included by running AcceptApiChanges.ps1 or AcceptApiChanges.sh.
• If the PR affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Please also run ./build.sh --target spellcheck or .\build.ps1 --target spellcheck before pushing and check the good outcome

[github-actions]

Qodana for .NET

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked

View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

1. Register at Qodana Cloud and configure the action
2. Use GitHub Code Scanning with Qodana
3. Host Qodana report at GitHub Pages
4. Inspect and use qodana.sarif.json (see the Qodana SARIF format for details)

To get *.log files or any other Qodana artifacts, run the action with upload-result option set to true,
so that the action will upload the files as the job artifacts:

      - name: 'Qodana Scan'
        uses: JetBrains/qodana-action@v2023.2.8
        with:
          upload-result: true

Contact Qodana team

Contact us at qodana-support@jetbrains.com

• Or via our issue tracker: https://jb.gg/qodana-issue
• Or share your feedback: https://jb.gg/qodana-discussions

[coveralls]

Pull Request Test Coverage Report for Build 6920937500

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

• 0 of 0 changed or added relevant lines in 0 files are covered.
• 7 unchanged lines in 3 files lost coverage.
• Overall coverage increased (+0.02%) to 97.475%

---

Files with Coverage Reduction	New Missed Lines	%
Src/FluentAssertions/Formatting/FormattedObjectGraph.cs	1	91.15%
Src/FluentAssertions/AssertionExtensions.cs	3	95.45%
Src/FluentAssertions/CallerIdentifier.cs	3	92.06%

Totals
Change from base Build 6874777002:	0.02%
Covered Lines:	11741
Relevant Lines:	11925

---

💛 - Coveralls

[dennisdoomen]

We should update the documentation (index.html, releases.md, etc) to mention that we're compatible with .NET 8.0

[IT-VBFK]

Should this be just a note that we are ".NET 8 ready", since we don't target .NET 8

[dennisdoomen]

Yes, something like that. Or we should rephrase all of the references to the frameworks. Like "Works with .NET Standard 2.0 and higher, .NET Framework 4.7 and higher and .NET 6 and higher"

[dennisdoomen]

I also think there are a couple of other places where we mention the version, including the NuGet description and such.

[vbreuss]

You were right. I found three more places 😄

[dennisdoomen]

103 new problems were found

This is something of a challenge as well. All the issues reported might be existing ones that now get redetected through .NET 8 target. We may have to update the baseline or bump the limit.

[vbreuss]

103 new problems were found

This is something of a challenge as well. All the issues reported might be existing ones that now get redetected through .NET 8 target. We may have to update the baseline or bump the limit.

How would I do this?

• Updating the baseline will have to be done by you, right?
• Bumping the limit would mean, increasing the failThreshold from 19 to 122 in qodana.yaml?

[vbreuss]

103 new problems were found

I had a look at the mentioned issues in the Files changed-Tab and most of them seem to be incorrect🤷:

• All issues are only for two files (AssertionExtensions.cs and CallerIdentifier.cs)
• The issues list (nearly) all using statements as incorrect.
  ,
• Also the cannot resolve reference in XML comment seem incorrect
  

[jnyrup]

According to https://youtrack.jetbrains.com/issue/QD-7660/Qodana-busted-in-.NET-8-RTM support for .NET 8 is not available yet, but will be with v233.
We're at QDNET-232.10203.29

[IT-VBFK]

@vbreuss Can you check what happens if you change args: --baseline,qodana.sarif.json,--ide,QDNET to args: --baseline,qodana.sarif.json,--ide,QDNET-EAP? Just to verify this fixes the issues...

[IT-VBFK]

Cool.. seems work 😉

[vbreuss]

@vbreuss Can you check what happens if you change args: --baseline,qodana.sarif.json,--ide,QDNET to args: --baseline,qodana.sarif.json,--ide,QDNET-EAP? Just to verify this fixes the issues...

Yes, it works.
previously it was

now it is

Will now undo the test...

[IT-VBFK]

@vbreuss FYI You could just have dropped the commit 😉

[IT-VBFK]

wow.. the qodana scan after this PR on develop 🙈

[dennisdoomen]

@vbreuss can you please put back that -EAP argument?

[vbreuss]

@vbreuss can you please put back that -EAP argument?

Of course, see #2474