A few fixed qodana issues

[ITaluone]

IMPORTANT

• If the PR touches the public API, the changes have been approved in a separate issue with the "api-approved" label.
• The code complies with the Coding Guidelines for C#.
• The changes are covered by unit tests which follow the Arrange-Act-Assert syntax and the naming conventions such as is used in these tests.
• If the PR adds a feature or fixes a bug, please update the release notes with a functional description that explains what the change means to consumers of this library, which are published on the website.
• If the PR changes the public API the changes needs to be included by running AcceptApiChanges.ps1 or AcceptApiChanges.sh.
• If the PR affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Please also run ./build.sh --target spellcheck or .\build.ps1 --target spellcheck before pushing and check the good outcome

[github-actions]

Qodana for .NET

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked

View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

1. Register at Qodana Cloud and configure the action
2. Use GitHub Code Scanning with Qodana
3. Host Qodana report at GitHub Pages
4. Inspect and use qodana.sarif.json (see the Qodana SARIF format for details)

To get *.log files or any other Qodana artifacts, run the action with upload-result option set to true,
so that the action will upload the files as the job artifacts:

      - name: 'Qodana Scan'
        uses: JetBrains/qodana-action@v2023.2.8
        with:
          upload-result: true

Contact Qodana team

Contact us at qodana-support@jetbrains.com

• Or via our issue tracker: https://jb.gg/qodana-issue
• Or share your feedback: https://jb.gg/qodana-discussions

[jnyrup]

I don't see Qodana complaining about this. Where do you see this?

Secondly, should we just silence that analyzer instead?

[ITaluone]

I don't see Qodana complaining about this. Where do you see this?

Pretty funny thing.. I accidentally double-clicked on the qodana.sarif.json inside Rider.. and suddenly the whole code was sprinkled with warnings 🙈
I think these are issues from the baseline report.

[jnyrup]

Secondly, should we just silence that analyzer instead?

If this cannot be automatically enforced on save across whatever IDE contributors are using, I don't think this consistency is worth pursuing, i.e. nagging contributors about.

Related comment about trailing commas.

[ITaluone]

So... if I understand this correctly: The manual enforcement of such rules are not what we want?

[ITaluone]

Ignoring trailing comma complaints

I left the first commit remaining, since redundant parentheses are both unnecessary and confusing sometimes

[coveralls]

Pull Request Test Coverage Report for Build 6531685737

• 3 of 3 (100.0%) changed or added relevant lines in 2 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 97.409%

---

Totals
Change from base Build 6525413142:	0.0%
Covered Lines:	11651
Relevant Lines:	11841

---

💛 - Coveralls