-
Notifications
You must be signed in to change notification settings - Fork 698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed binary formatter #2278
Removed binary formatter #2278
Conversation
Qodana for .NETIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at qodana-support@jetbrains.com
|
Pull Request Test Coverage Report for Build 6396364562
💛 - Coveralls |
I thought we wanted to completely get rid of it, right @jnyrup |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
From BinaryFormatter Obsoletion Strategy: So, why removing code for supported targets? |
4906a14
to
4fa6185
Compare
4fa6185
to
0b7424e
Compare
0b7424e
to
3a41275
Compare
This fixes #1779.
The
BinaryFormatter
is deprecated. So, it will not get part of the planned net8 target.For all other targets it has been marked as obsolete, which is a breaking change.After disussion in the linked issue, the support is finally removed completely.
IMPORTANT
./build.sh --target spellcheck
or.\build.ps1 --target spellcheck
before pushing and check the good outcome