Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare for .NET8 analyzers #2228

Merged
merged 6 commits into from
Jun 23, 2023
Merged

Prepare for .NET8 analyzers #2228

merged 6 commits into from
Jun 23, 2023

Commits on Jun 14, 2023

  1. Remove whitespace

    @jnyrup
    jnyrup committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    018d5ee View commit details
    Browse the repository at this point in the history

  2. Make member readonly

    @jnyrup
    jnyrup committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    a8e9a22 View commit details
    Browse the repository at this point in the history

  3. Suppress CA1861 for tests to avoid over-DRY

    @jnyrup
    jnyrup committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    6327230 View commit details
    Browse the repository at this point in the history

  4. Add yet another supression for type outside namespace

    @jnyrup
    jnyrup committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    eea11b0 View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2023

  1. Ignore CA1859 until reported issue is fixed

    @jnyrup
    jnyrup committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    d0faf69 View commit details
    Browse the repository at this point in the history

Commits on Jun 23, 2023

  1. Exclude CA1861 

    The analyzer is probably right, but the fix would be a named static field, which would reduce code locality. As I don't think these places are hot-paths, we prefer code locality over _potential_ performance increase.

Right now it triggered in these members:
* ObjectReference.GetPathElements
* StringExtensions.IndentLines
* MemberPath.Segments
    @jnyrup
    jnyrup committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    26db797 View commit details
    Browse the repository at this point in the history