Extend AssemblyAssertions with HavePublicKey and BeUnsigned

[Corniel]

To ensures that the public key of an signed assembly does not accidentally changes, having an assertion .HasPublicKey(string) can help. Hence this PR. For completeness/symmetry reasons I also added .BeUnsigned().

IMPORTANT

• If the PR touches the public API, the changes have been approved in a separate issue with the "api-approved" label.
• The code complies with the Coding Guidelines for C#.
• The changes are covered by unit tests which follow the Arrange-Act-Assert syntax and the naming conventions such as is used in these tests.
• If the PR adds a feature or fixes a bug, please update the release notes with a functional description that explains what the change means to consumers of this library, which are published on the website.
• If the PR changes the public API the changes needs to be included by running AcceptApiChanges.ps1 or AcceptApiChanges.sh.
• If the PR affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Please also run ./build.sh --target spellcheck or .\build.ps1 --target spellcheck before pushing and check the good outcome

Relevant issue: #2209

[dennisdoomen]

Thank you for this proposal. As you can see from the checklist, the idea is that you first create an issue with an API proposal so we can discuss the consequences. But since we know each other let's see if we can take this PR further 🫢

[lg2de]

When writing the API proposal, please check whether asserting signature fingerprint only is possible and - maybe - easier to use.

[Corniel]

Thank you for this proposal. As you can see from the checklist, the idea is that you first create an issue with an API proposal so we can discuss the consequences. But since we know each other let's see if we can take this PR further 🫢

I know. I had the code already, and I was not sure my self yet which API to propose. That's the reason I already started this PR. But if this a desired extension to the API, and if not, what to add (or to add this at all) definitionally should be discussed too.

[jnyrup]

It looks promising, but let's discuss the API in a GH issue first.
The issue template contains questions that help ensuring we're on the same line and reach the better design.

That people already started commenting on the implementation before the shape was agreed upon proves the need to keep these thing separate.

[Corniel]

@dennisdoomen :Note that locally my build fails, as it claims that C#11 features are not available, and all warnings are handled as errors. Can someone enlighten me on why that could happen?

[jnyrup]

Do you have the .NET 7 SDK installed? Our global.json file should specify the minimum required version.

[Corniel]

Do you have the .NET 7 SDK installed? Our global.json file should specify the minimum required version.

Yes I have. Both for my company and multiple open source projects I work on require that. As mentioned, also the thing that (and that only happens for this solution) all warnings are handled as errors is strange.

[dennisdoomen]

Yes I have. Both for my company and multiple open source projects I work on require that. As mentioned, also the thing that (and that only happens for this solution) all warnings are handled as errors is strange.

I recommend joining our Slack to have a more efficient discussion. You can use this invite.

[dennisdoomen]

• Please assume comments also apply to other places in the PR.
• Also update the releases.md and the assemblies.md

[coveralls]

Pull Request Test Coverage Report for Build 5705024583

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

• For more information on this, see Tracking coverage changes with pull request builds.
• To avoid this issue with future PRs, see these Recommended CI Configurations.
• For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

• 29 of 29 (100.0%) changed or added relevant lines in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage decreased (-0.006%) to 97.217%

---

Totals
Change from base Build 5672891851:	-0.006%
Covered Lines:	12890
Relevant Lines:	13132

---

💛 - Coveralls

[jnyrup]

Looks good 👍

Please also add an example to the docs
and update the release notes

[Corniel]

I think I addressed all concerns.

[IT-VBFK]

Quick question: Are you able to run ./build.sh (or .\build.ps1 respectively) on you dev device? And is it failing there too?

[Corniel]

Quick question: Are you able to run ./build.sh (or .\build.ps1 respectively) on you dev device? And is it failing there too?

It fails with:

  // FileNotFoundException: Could not load file or assembly 'System.Runtime, Version=7.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'. The system cannot find the file specified.

I don't think that is related to my changes.

[IT-VBFK]

Looks like macOS, doesn't it? Have the same problem :)

[Corniel]

Looks like macOS, doesn't it? Have the same problem :)

Might be, but this is on a good all Windows laptop. :D

[dennisdoomen]

@Corniel well done. It took a while, but you made it ;-)

[jnyrup]

Yeah, thanks for the patience. It was an API that to grow some on me.

[Corniel]

Well, it was worth it. I had get custom your way of working too, obviously. I think I did.

@jnyrup Thanks for your patience too.