Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup #2201

Merged
merged 2 commits into from
May 8, 2023
Merged

Cleanup #2201

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0fc9485
Prefer Which over And for chaining
jnyrup May 7, 2023
d05338f
Change from Invariant->Ordinal
jnyrup Apr 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion Build/Build.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -384,5 +384,5 @@ void ReportTestOutcome(params string[] globFilters)

bool RunAllTargets => string.IsNullOrWhiteSpace(PullRequestBase) || Changes.Any(x => x.StartsWith("Build"));

bool IsTag => BranchSpec != null && BranchSpec.Contains("refs/tags", StringComparison.InvariantCultureIgnoreCase);
bool IsTag => BranchSpec != null && BranchSpec.Contains("refs/tags", StringComparison.OrdinalIgnoreCase);
}
2 changes: 1 addition & 1 deletion Tests/FluentAssertions.Equivalency.Specs/ExtensibilitySpecs.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,7 +245,7 @@ public void Can_exclude_all_properties_of_the_parent_type()
subject.Should().BeEquivalentTo(expectation,
o => o
.Using<string>(c => c.Subject.Should().HaveLength(c.Expectation.Length))
.When(si => si.ParentType == expectation.GetType() && si.Path.EndsWith("Id", StringComparison.InvariantCulture)));
.When(si => si.ParentType == expectation.GetType() && si.Path.EndsWith("Id", StringComparison.Ordinal)));
}

[Fact]
Expand Down
12 changes: 6 additions & 6 deletions Tests/FluentAssertions.Specs/Formatting/FormatterSpecs.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,7 @@ public void When_the_object_is_a_generic_type_without_custom_string_representati

// Assert
act.Should().Throw<XunitException>()
.And.Message.Should().Match(
.WithMessage(
"""
Expected stuff to be equal to
{
Expand Down Expand Up @@ -256,7 +256,7 @@ public void When_the_object_is_a_user_defined_type_it_should_show_the_name_on_th

// Assert
act.Should().Throw<XunitException>()
.And.Message.Should().Be(
.Which.Message.Should().Be(
"""
Expected stuff to be <null>, but found FluentAssertions.Specs.Formatting.FormatterSpecs+StuffRecord
{
Expand Down Expand Up @@ -293,7 +293,7 @@ public void When_the_object_is_an_anonymous_type_it_should_show_the_properties_r

// Assert
act.Should().Throw<XunitException>()
.And.Message.Should().Be(
.Which.Message.Should().Be(
"""
Expected stuff to be
{
Expand Down Expand Up @@ -347,7 +347,7 @@ public void When_the_object_is_a_list_of_anonymous_type_it_should_show_the_prope

// Assert
act.Should().Throw<XunitException>()
.And.Message.Should().StartWith(
.Which.Message.Should().StartWith(
"""
Expected stuff to be a collection with 1 item(s), but
{
Expand Down Expand Up @@ -405,7 +405,7 @@ public void When_the_object_is_a_tuple_it_should_show_the_properties_recursively

// Assert
act.Should().Throw<XunitException>()
.And.Message.Should().Be(
.Which.Message.Should().Be(
"""
Expected stuff to be equal to
{
Expand Down Expand Up @@ -441,7 +441,7 @@ public void When_the_object_is_a_record_it_should_show_the_properties_recursivel

// Assert
act.Should().Throw<XunitException>()
.And.Message.Should().Be(
.Which.Message.Should().Be(
"""
Expected stuff to be
{
Expand Down