CA1860: Avoid using 'Enumerable.Any()' extension method

[Evangelink]

Fixes newly enabled .NET analyzers CA1860 rule. More information about the rule at https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1860

IMPORTANT

• If the PR touches the public API, the changes have been approved in a separate issue with the "api-approved" label.
• The code complies with the Coding Guidelines for C#.
• The changes are covered by unit tests which follow the Arrange-Act-Assert syntax and the naming conventions such as is used in these tests.
• If the PR adds a feature or fixes a bug, please update the release notes with a functional description that explains what the change means to consumers of this library, which are published on the website.
• If the PR changes the public API the changes needs to be included by running AcceptApiChanges.ps1 or AcceptApiChanges.sh.
• If the PR affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Please also run ./build.sh --target spellcheck or .\build.ps1 --target spellcheck before pushing and check the good outcome

[Evangelink]

Sorry not sure what happened, I had no error locally but now I do reproduce the same errors. Will investigate and mark as ready when build is passing locally.

[jnyrup]

Fixes newly enabled .NET analyzers CA1860 rule.

Since we don't have very performance sensitive code, I don't have a strong opinion on whether or not we should limit the usage of Any.
But if we do, we should stricten the analyzer to enforce it.

[dennisdoomen]

Since we don't have very performance sensitive code, I don't have a strong opinion on whether or not we should limit the usage of Any. But if we do, we should stricten the analyzer to enforce it.

It depends on the run-time version. As of .NET Core 2.0, Any will be check whether you're calling it on an array or collection and directly use the Count property. The .NET 4.x version isn't that smart.

But I agree. Totally fine to enable this rule.

[jnyrup]

Thinking more about it, I'm pro enforcing this.
Limiting the usage of Any should help spotting places where we do multiple enumerations on lazy non-materialized enumerables.

Related analyzer and issue:

fluentassertions/.editorconfig

Lines 153 to 154 in 22a6039

	# CA1851: Possible multiple enumerations of IEnumerable collection. Related to GH-issue #2000
	dotnet_diagnostic.CA1851.severity = suggestion

[Evangelink]

Will fix this PR and enable the rule today. Sorry for the delay, I was held back by some other tasks.

[Evangelink]

Sorry for the delay here and multiple commits.... Hope this PR will help!

Thanks for the awesome tool :)

[coveralls]

Pull Request Test Coverage Report for Build 4939159012

• 62 of 62 (100.0%) changed or added relevant lines in 20 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 97.204%

---

Totals
Change from base Build 4926739040:	0.0%
Covered Lines:	12867
Relevant Lines:	13109

---

💛 - Coveralls