Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actions workflow - Add new OS's, Ruby 3.1, Ruby master, Windows #491

Merged
merged 1 commit into from
Mar 8, 2023

Conversation

MSP-Greg
Copy link
Contributor

No description provided.

@MSP-Greg
Copy link
Contributor Author

MSP-Greg commented Jan 15, 2022

This PR uses ruby/setup-ruby-pkgs, as ragel needs to be installed on Ubuntu & macOS platforms. Cross platform package installation is essentially the only reason for the action. It uses the code from ruby/setup-ruby for all the operations it performs.

The PR also adds all MRI head builds, including Windows mswin.

@MSP-Greg
Copy link
Contributor Author

Rebased and updated - ubuntu-22.04, macos-12, Windows mswin

@MSP-Greg MSP-Greg changed the title Actions workflow - Add Ruby 3.1, Ruby master, Windows, Update version Actions workflow - Add new OS's, Ruby 3.1, Ruby master, Windows May 18, 2022
@hsbt
Copy link
Collaborator

hsbt commented Mar 8, 2023

@MSP-Greg Sorry to request again. Can you rebase from master branch? I'd like to merge ruby/setup-ruby-pkgs@v1 and ragel installation changes.

@MSP-Greg
Copy link
Contributor Author

MSP-Greg commented Mar 8, 2023

@hsbt Done. I added workflow_dispatch, which can be helpful here or in forks for checking intermittent failures/errors, etc.

@MSP-Greg
Copy link
Contributor Author

MSP-Greg commented Mar 8, 2023

@hsbt A little off topic, but would a workflow that checks whether ext/json/ext/parser/parser.rl matches ext/json/ext/parser/parser.c be helpful? Puma has one, and it checks that any change to the *.rl is also done to the *.c file.

Or, it checks that ragel produces the commited c file from the commited rl file...

Regardless, it will be tomorrow at the earliest, 23:35 here.

@hsbt hsbt merged commit c233be9 into flori:master Mar 8, 2023
@hsbt
Copy link
Collaborator

hsbt commented Mar 8, 2023

diff checker of ragel is helpful. But https://github.com/puma/puma/blob/master/.github/workflows/ragel.yml seems too large for only checking. It may be hard to maintain in the future.

@MSP-Greg MSP-Greg deleted the actions branch October 11, 2023 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants