static: only strip if the file path is not a single slash #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #171 +/- ##
==========================================
+ Coverage 89.49% 89.52% +0.02%
==========================================
Files 17 17
Lines 1152 1155 +3
==========================================
+ Hits 1031 1034 +3
Misses 80 80
Partials 41 41 |
unknwon
approved these changes
Aug 8, 2023
unknwon
requested changes
Aug 8, 2023
The previous test case does not cover this case, so it passed. |
unknwon
approved these changes
Aug 8, 2023
|
https://github.com/flamego/flamego/releases/tag/v1.9.4 has been created for this merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request
I apologize for my carelessness. This PR is related to fixing the previous one. #170
When the
Indexfile is placed in the root path of the go embed file system, the single slash/will be trimmed to an empty string. The go embed file system also can not accept it. 馃槀I have fixed it in this PR and added the test case.
Link to the issue: n/a
Checklist