Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(test): Remove ignorance of RUSTSEC-2021-0145 #3799

Merged
merged 2 commits into from
Jun 6, 2023

Conversation

zulinx86
Copy link
Contributor

@zulinx86 zulinx86 commented Jun 6, 2023

Changes

Removes the ignorance of RUSTSEC-2021-0145 from cargo audit test.

Reason

Now we're consuming criterion 0.5.1 that no longer depends on atty.

Closes #3284

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following
Developer Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.

PR Checklist

  • If a specific issue led to this PR, this PR closes the issue.
  • The description of changes is clear and encompassing.
  • [ ] Any required documentation changes (code and docs) are included in this PR.
  • [ ] API changes follow the Runbook for Firecracker API changes.
  • [ ] User-facing changes are mentioned in CHANGELOG.md.
  • All added/changed functionality is tested.
  • [ ] New TODOs link to an issue.
  • Commits meet contribution quality standards.

  • This functionality cannot be added in rust-vmm.

Now that we're consuming criterion 0.5.1 that no longer depends on atty,
removes the ignorance of RUSTSEC-2021-0145 from cargo audit test.

Signed-off-by: Takahiro Itazuri <itazur@amazon.com>
@zulinx86 zulinx86 self-assigned this Jun 6, 2023
@zulinx86 zulinx86 added the Status: Awaiting review Indicates that a pull request is ready to be reviewed label Jun 6, 2023
@zulinx86 zulinx86 requested a review from roypat June 6, 2023 15:51
Copy link
Contributor

@roypat roypat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I think removing this is good - will prevent us from accidentally reintroducing this dependency further down the line, as our cargo audit CI step will fail. Thanks Taka!

@zulinx86 zulinx86 merged commit 2267b59 into firecracker-microvm:main Jun 6, 2023
4 checks passed
@zulinx86 zulinx86 deleted the audit branch June 6, 2023 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Awaiting review Indicates that a pull request is ready to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Upstream] atty crate has unsoundness bug
3 participants