Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(firebase_ui_auth): Error added in ProfileScreen in firebase_ui_auth 1.4.0 #10957

Merged
merged 3 commits into from
May 17, 2023

Commits on May 12, 2023

  1. Fix Error:

    zachary-russell committed May 12, 2023
    Configuration menu
    Copy the full SHA
    1f0c136 View commit details
    Browse the repository at this point in the history

Commits on May 15, 2023

  1. fix(test): get tests to pass

    The prefer_const_constructors warning is ignored in this case because the LoadingIndicator widget used inside the children list of the Row does not have a const constructor. This is due to the fact that LoadingIndicator extends PlatformWidget, which doesn't have a const constructor, making it impossible to have a const constructor for LoadingIndicator. Since we can't make the LoadingIndicator constructor const, we have to ignore the warning for the specific Row constructor. This is an acceptable solution in cases like this, where making the constructor const is not feasible or possible.
    zachary-russell committed May 15, 2023
    Configuration menu
    Copy the full SHA
    9aa4173 View commit details
    Browse the repository at this point in the history

Commits on May 16, 2023

  1. fix: revert changes

    zachary-russell committed May 16, 2023
    Configuration menu
    Copy the full SHA
    fd3fc54 View commit details
    Browse the repository at this point in the history