Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add check for empty device list #6750

Merged
merged 1 commit into from
Feb 7, 2024
Merged

Add check for empty device list #6750

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/commands/appdistribution-distribute.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,12 +76,12 @@
"run automated tests without waiting for them to complete. Visit the Firebase console for the test results.",
)
.before(requireAuth)
.action(async (file: string, options: any) => {

Check warning on line 79 in src/commands/appdistribution-distribute.ts

View workflow job for this annotation

GitHub Actions / lint (20) 

Unexpected any. Specify a different type
const appName = getAppName(options);
const distribution = new Distribution(file);
const releaseNotes = getReleaseNotes(options.releaseNotes, options.releaseNotesFile);

Check warning on line 82 in src/commands/appdistribution-distribute.ts

View workflow job for this annotation

GitHub Actions / lint (20) 

Unsafe argument of type `any` assigned to a parameter of type `string`

Check warning on line 82 in src/commands/appdistribution-distribute.ts

View workflow job for this annotation

GitHub Actions / lint (20) 

Unsafe member access .releaseNotes on an `any` value

Check warning on line 82 in src/commands/appdistribution-distribute.ts

View workflow job for this annotation

GitHub Actions / lint (20) 

Unsafe argument of type `any` assigned to a parameter of type `string`

Check warning on line 82 in src/commands/appdistribution-distribute.ts

View workflow job for this annotation

GitHub Actions / lint (20) 

Unsafe member access .releaseNotesFile on an `any` value
const testers = getTestersOrGroups(options.testers, options.testersFile);

Check warning on line 83 in src/commands/appdistribution-distribute.ts

View workflow job for this annotation

GitHub Actions / lint (20) 

Unsafe argument of type `any` assigned to a parameter of type `string`

Check warning on line 83 in src/commands/appdistribution-distribute.ts

View workflow job for this annotation

GitHub Actions / lint (20) 

Unsafe member access .testers on an `any` value

Check warning on line 83 in src/commands/appdistribution-distribute.ts

View workflow job for this annotation

GitHub Actions / lint (20) 

Unsafe argument of type `any` assigned to a parameter of type `string`

Check warning on line 83 in src/commands/appdistribution-distribute.ts

View workflow job for this annotation

GitHub Actions / lint (20) 

Unsafe member access .testersFile on an `any` value
const groups = getTestersOrGroups(options.groups, options.groupsFile);

Check warning on line 84 in src/commands/appdistribution-distribute.ts

View workflow job for this annotation

GitHub Actions / lint (20) 

Unsafe argument of type `any` assigned to a parameter of type `string`
const testDevices = getTestDevices(options.testDevices, options.testDevicesFile);
const loginCredential = getLoginCredential({
username: options.testUsername,
Expand Down Expand Up @@ -210,7 +210,7 @@
await requests.distribute(releaseName, testers, groups);

// Run automated tests
if (testDevices) {
if (testDevices?.length) {
utils.logBullet("starting automated tests (note: this feature is in beta)");
const releaseTest = await requests.createReleaseTest(
releaseName,
Expand Down