Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dynamically import Vite #6660

Merged
merged 15 commits into from
Jan 23, 2024
Merged

dynamically import Vite #6660

merged 15 commits into from
Jan 23, 2024

Conversation

leoortizz
Copy link
Member

Description

closes #6652

Scenarios Tested

Sample Commands

@codecov-commenter
Copy link

codecov-commenter commented Jan 2, 2024

Codecov Report

Attention: 17 lines in your changes are missing coverage. Please review.

Comparison is base (7717b83) 54.15% compared to head (0dc915c) 54.15%.

Files Patch % Lines
src/frameworks/utils.ts 20.00% 8 Missing ⚠️
src/frameworks/angular/utils.ts 0.00% 4 Missing ⚠️
src/frameworks/next/index.ts 0.00% 2 Missing ⚠️
src/frameworks/vite/index.ts 0.00% 2 Missing ⚠️
src/frameworks/angular/index.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6660   +/-   ##
=======================================
  Coverage   54.15%   54.15%           
=======================================
  Files         347      347           
  Lines       24133    24133           
  Branches     4978     4981    +3     
=======================================
  Hits        13070    13070           
  Misses       9862     9862           
  Partials     1201     1201           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/frameworks/utils.ts Outdated Show resolved Hide resolved
@leoortizz leoortizz requested review from jamesdaniels and removed request for jamesdaniels January 23, 2024 15:42
Copy link
Member

@jamesdaniels jamesdaniels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add changelog, otherwise LGTM

@leoortizz leoortizz enabled auto-merge (squash) January 23, 2024 15:51
@leoortizz leoortizz merged commit 04cd545 into master Jan 23, 2024
35 checks passed
@leoortizz leoortizz deleted the leoortizz_viteDynamicImport branch January 23, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The CJS build of Vite's Node API is deprecated.
3 participants