ng-deploy may not have configurations configured...

CHANGELOG.md

@@ -0,0 +1 @@
+- Fixed an issue preventing Angular apps using ng-deploy from being emulated or deployed. (#6584)

src/frameworks/angular/utils.ts

@@ -10,7 +10,7 @@
 import { AssertionError } from "assert";
 import { assertIsString } from "../../utils";
 
 async function localesForTarget(
   dir: string,
   architectHost: WorkspaceNodeModulesArchitectHost,
   target: Target,
@@ -26,7 +26,7 @@
   let locales: string[] | undefined = undefined;
   let defaultLocale: string | undefined = undefined;
   if (targetOptions.localize) {
     const i18n: AngularI18nConfig | undefined = workspaceProject.extensions?.i18n as any;
     if (!i18n) throw new FirebaseError(`No i18n config on project.`);
     if (typeof i18n.sourceLocale === "string") {
       throw new FirebaseError(`All your i18n locales must have a baseHref of "" on Firebase, use an object for sourceLocale in your angular.json:
@@ -48,7 +48,7 @@
       for (const [locale, { baseHref }] of Object.entries(i18n.locales)) {
         if (baseHref !== "")
           throw new FirebaseError(
             `All your i18n locales must have a baseHref of \"\" on Firebase, errored on ${locale}.`
           );
         locales.push(locale);
       }
@@ -95,7 +95,7 @@
   ];
 }
 
 export async function getAllTargets(purpose: BUILD_TARGET_PURPOSE, dir: string) {
   const validBuilders = getValidBuilders(purpose);
   const { NodeJsAsyncHost } = relativeRequire(dir, "@angular-devkit/core/node");
   const { workspaces } = relativeRequire(dir, "@angular-devkit/core");
@@ -121,7 +121,7 @@
 }
 
 // TODO(jamesdaniels) memoize, dry up
 export async function getContext(dir: string, targetOrConfiguration?: string) {
   const { NodeJsAsyncHost } = relativeRequire(dir, "@angular-devkit/core/node");
   const { workspaces } = relativeRequire(dir, "@angular-devkit/core");
   const { WorkspaceNodeModulesArchitectHost } = relativeRequire(
@@ -161,7 +161,7 @@
   }
 
   if (!project) {
     const angularJson = parse(await host.readFile(join(dir, "angular.json")));
     project = angularJson.defaultProject;
   }
 
@@ -220,7 +220,9 @@
   }
 
   if (deployTarget) {
-    const options = await architectHost.getOptionsForTarget(deployTarget);
+    const options = await architectHost
+      .getOptionsForTarget(deployTarget)
+      .catch(() => workspaceProject.targets.get(deployTarget!.target)?.options);
     if (!options) throw new FirebaseError("Unable to get options for ng-deploy.");
     if (options.buildTarget) {
       assertIsString(options.buildTarget);
@@ -238,6 +240,10 @@
       assertIsString(options.serverTarget);
       serverTarget = targetFromTargetString(options.serverTarget);
     }
+    if (options.serveTarget) {
+      assertIsString(options.serveTarget);
+      serveTarget = targetFromTargetString(options.serveTarget);
+    }
     if (options.serveOptimizedImages) {
       serveOptimizedImages = true;
     }