Memoize firestore.getDatabase API calls when deploying Firestore functions

CHANGELOG.md

@@ -1,3 +1,4 @@
+- Fix bug where deploying Firestore function resulted in redudant API calls to the Firestore API (#6583).
 - Fix an issue preventing Vite applications from being emulated on Windows. (#6411)
 - Addressed an issue preventing Astro applications from being deployed from Windows. (#5709)
 - Fixed an issue preventing Angular apps using ng-deploy from being emulated or deployed. (#6584)

src/deploy/functions/services/firestore.ts

@@ -2,14 +2,32 @@
 import * as firestore from "../../../gcp/firestore";
 import { FirebaseError } from "../../../error";
 
+const dbCache = new Map<string, firestore.Database>();
+
+/**
+ * A memoized version of firestore.getDatabase that avoids repeated calls to the API.
+ *
+ * @param project the project ID
+ * @param databaseId the database ID or "(default)"
+ */
+async function getDatabase(project: string, databaseId: string): Promise<firestore.Database> {
+  const key = `${project}/${databaseId}`;
+  if (dbCache.has(key)) {
+    return dbCache.get(key)!;
+  }
+  const db = await firestore.getDatabase(project, databaseId);
+  dbCache.set(key, db);
+  return db;
+}
+
 /**
  * Sets a firestore event trigger's region to the firestore database region.
  * @param endpoint the firestore endpoint
  */
 export async function ensureFirestoreTriggerRegion(
   endpoint: backend.Endpoint & backend.EventTriggered
 ): Promise<void> {
-  const db = await firestore.getDatabase(
+  const db = await getDatabase(
     endpoint.project,
     endpoint.eventTrigger.eventFilters?.database || "(default)"
   );

src/gcp/firestore.ts

@@ -8,7 +8,7 @@
   urlPrefix: firestoreOrigin,
 });
 
-interface Database {
+export interface Database {
   name: string;
   uid: string;
   createTime: string;
@@ -57,7 +57,7 @@
     pageSize: 2147483647,
   };
 
   return apiClient.post<any, { collectionIds?: string[] }>(url, data).then((res) => {
     return res.body.collectionIds || [];
   });
 }
@@ -71,8 +71,8 @@
  * @param {object} doc a Document object to delete.
  * @return {Promise} a promise for the delete operation.
  */
 export async function deleteDocument(doc: any): Promise<any> {
   return apiClient.delete(doc.name);
 }
 
 /**
@@ -85,14 +85,14 @@
  * @param {object[]} docs an array of Document objects to delete.
  * @return {Promise<number>} a promise for the number of deleted documents.
  */
 export async function deleteDocuments(project: string, docs: any[]): Promise<number> {
   const url = "projects/" + project + "/databases/(default)/documents:commit";
 
   const writes = docs.map((doc) => {
     return { delete: doc.name };
   });
   const data = { writes };
 
   const res = await apiClient.post<any, { writeResults: any[] }>(url, data);
   return res.body.writeResults.length;
 }